godfreyhe commented on a change in pull request #9116: [FLINK-13264][table] Let
the planner supply its type inference util
URL: https://github.com/apache/flink/pull/9116#discussion_r303398132
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/PlannerBase.scala
##########
@@ -40,16 +40,16 @@ import org.apache.flink.table.sinks.{DataStreamTableSink,
TableSink, TableSinkUt
import org.apache.flink.table.sqlexec.SqlToOperationConverter
import org.apache.flink.table.types.utils.LegacyTypeInfoDataTypeConverter
import org.apache.flink.table.util.JavaScalaConversionUtil
-
import org.apache.calcite.jdbc.CalciteSchemaBuilder.asRootSchema
import org.apache.calcite.plan.{RelTrait, RelTraitDef}
import org.apache.calcite.rel.RelNode
import org.apache.calcite.sql.{SqlIdentifier, SqlInsert, SqlKind}
import org.apache.calcite.tools.FrameworkConfig
-
import _root_.java.util.{List => JList}
import java.util
+import org.apache.flink.table.expressions.PlannerTypeInferenceUtilImpl
Review comment:
nit: move this line up to the `org.apache.flink.table.XXX` part ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
