godfreyhe commented on a change in pull request #9119: [FLINK-13268]
[table-planner-blink] Revert SqlSplittableAggFunction to support making two
planners available in one jar
URL: https://github.com/apache/flink/pull/9119#discussion_r303437551
##########
File path:
flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/plan/rules/logical/AggregateReduceGroupingRuleTest.xml
##########
@@ -107,11 +107,10 @@ LogicalAggregate(group=[{0, 1, 2, 3}],
EXPR$4=[COUNT($4)], EXPR$5=[AVG($5)])
</Resource>
<Resource name="planAfter">
<![CDATA[
-FlinkLogicalCalc(select=[a2, b2, a3, b3, *($f2, $f20) AS EXPR$4,
/(CAST(CASE(=($f4, 0), null:BIGINT, $f3)), $f4) AS EXPR$5])
-+- FlinkLogicalJoin(condition=[=($1, $3)], joinType=[inner])
- :- FlinkLogicalCalc(select=[a2, b2, CAST(CASE(IS NOT NULL(c2), 1, 0)) AS
$f2])
- : +- FlinkLogicalTableSourceScan(table=[[default_catalog,
default_database, T2, source: [TestTableSource(a2, b2, c2)]]], fields=[a2, b2,
c2])
- +- FlinkLogicalAggregate(group=[{0, 1}], agg#0=[COUNT()],
agg#1=[$SUM0($2)], agg#2=[COUNT($2)])
+FlinkLogicalCalc(select=[a2, b2, a3, b3, EXPR$4, EXPR$5])
Review comment:
as above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
