xintongsong commented on issue #9105: [FLINK-13241][Yarn/Mesos] Fix 
Yarn/MesosResourceManager setting managed memory size into wrong configuration 
instance.
URL: https://github.com/apache/flink/pull/9105#issuecomment-511626675
 
 
   Thanks for the comment, @azagrebin.
   However, I'm not sure whether we need another test case to cover this issue, 
since we already have `YarnResourceManagerTest#testCreateSlotsPerWorker`. This 
test case was using the wrong instance for TM side calculation, which is also 
fixed in this PR. It should fail now if RM did not set the configuration 
instance for starting TM correctly.
   Maybe I'm overlooking something that may trigger this bug again without 
failing the existing test cases?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to