wuchong commented on a change in pull request #9120:
[FLINK-13216][FLINK-13153][table-planner-blink] Fix Max_Retract and Min_Retract
may produce incorrect result
URL: https://github.com/apache/flink/pull/9120#discussion_r303715525
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/functions/aggfunctions/MinWithRetractAggFunction.java
##########
@@ -195,7 +197,7 @@ public void resetAccumulator(MinWithRetractAccumulator<T>
acc) {
@Override
public T getValue(MinWithRetractAccumulator<T> acc) {
- if (acc.mapSize != 0) {
+ if (acc.mapSize > 0) {
Review comment:
I just added this for safety. This is not the cause of this problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
