[
https://issues.apache.org/jira/browse/FLINK-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14904292#comment-14904292
]
ASF GitHub Bot commented on FLINK-2694:
---------------------------------------
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1145#issuecomment-142553329
This is more robust, because Akka has retry loop when trying to bind to the
randomly picked port, right? The change looks good and works fine. +1
Optional: I would add two comments to test: one that the log4j log level
needs to be >= INFO and that the log message needs to be "Starting
JobManager...". If one of these two things changes, the test will not work
anymore and it might be helpful for debugging if it every happens.
> JobManagerProcessReapingTest.testReapProcessOnFailure failed on Travis
> ----------------------------------------------------------------------
>
> Key: FLINK-2694
> URL: https://issues.apache.org/jira/browse/FLINK-2694
> Project: Flink
> Issue Type: Bug
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Critical
> Labels: test-stability
>
> I observed a failing
> {{JobManagerProcessReapingTest.testReapProcessOnFailure}} test case on
> Travis. The reason for the test failure seems to be that the {{JobManager}}
> could not be started. The reason for this was that Netty could not bind to
> the specified port.
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/80642036/log.txt
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
