Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1145#issuecomment-142553329
This is more robust, because Akka has retry loop when trying to bind to the
randomly picked port, right? The change looks good and works fine. +1
Optional: I would add two comments to test: one that the log4j log level
needs to be >= INFO and that the log message needs to be "Starting
JobManager...". If one of these two things changes, the test will not work
anymore and it might be helpful for debugging if it every happens.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
