azagrebin opened a new pull request #9126: [FLINK-13242][tests][coordination] Get SlotManager.failUnfulfillableRequest in main thread of StandaloneResourceManager for verification in StandaloneResourceManagerTest URL: https://github.com/apache/flink/pull/9126 ## What is the purpose of the change In `StandaloneResourceManagerTest` we check `isFailingUnfulfillableRequest` in the test thread, although the underlying field `SlotManager.failUnfulfillableRequest` has no synchronisation and set in the main thread of `StandaloneResourceManager`. This can lead to a visibility problem of `SlotManager.failUnfulfillableRequest`: set in the main thread of `StandaloneResourceManager` but never updated in the test thread. ## Brief change log The idea for the fix is read `SlotManager.failUnfulfillableRequest` in the main thread of `StandaloneResourceManager`, get future result and check in the `StandaloneResourceManagerTest.assertHappensUntil`. ## Verifying this change run `StandaloneResourceManagerTest` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
