Myasuka commented on issue #9123: [FLINK-13281] Fix the verify logic of AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest URL: https://github.com/apache/flink/pull/9123#issuecomment-511727785 @tillrohrmann I would try to interpret this more clearly below: After [FLINK-13060](https://issues.apache.org/jira/browse/FLINK-13060), `AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest` still use previous `InfiniteDelayRestartStrategy` which means `AdaptedRestartPipelinedRegionStrategyNG#resetTasks()` would never be called when some task failed. The root cause why previous `AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest` could still pass is because of the pending checkpoints are aborted by `failUnacknowledgedPendingCheckpointsFor()` method in `CheckpointCoordinator` (which is actually introduced vai [FLINK-7844](https://issues.apache.org/jira/browse/FLINK-7844) ). In a nutshell, we expect pending checkpoints are aborted by `AdaptedRestartPipelinedRegionStrategyNG#resetTasks()` not `CheckpointCoordinator#failUnacknowledgedPendingCheckpointsFor()`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
