Myasuka opened a new pull request #9128: [FLINK-13256] Ensure periodical checkpoint still valid when region failover abort pending checkpoints URL: https://github.com/apache/flink/pull/9128 ## What is the purpose of the change After we introduce region failover, pending checkpoints would be aborted when task failed. However, previous implementation would come across a bug leading to periodical checkpoint is invalid. Previously, when checkpoint coordinator trigger a checkpoint and the size of pending checkpoints is larger than `maxConcurrentCheckpointAttempts` (default 1), it would just assign the `currentPeriodicTrigger` to null. However, the pending checkpoints would then possibly be aborted due to region failover, which lead to no pending checkpoints and no `currentPeriodicTrigger`. In the end, the periodical checkpoint mechanism would become not valid anymore. ## Brief change log - Ensure when `CheckpointCoordinator` abort pending checkpoints, the `currentPeriodicTrigger` would must not be null. - Add test `FailoverStrategyCheckpointCoordinatorTest` to verify this case. ## Verifying this change This change added tests and can be verified as follows: - Added test `FailoverStrategyCheckpointCoordinatorTest` to verify `currentPeriodicTrigger` is not null when `checkpointCoordinator#abortPendingCheckpointsWithTriggerValidation` is called. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): **no** - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no** - The serializers: **no** - The runtime per-record code paths (performance sensitive): **no** - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no** - The S3 file system connector: **no** ## Documentation - Does this pull request introduce a new feature? **no** - If yes, how is the feature documented? **not applicable**
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
