mchro commented on a change in pull request #8967: [FLINK-13059][Cassandra
Connector] Release Semaphore correctly on Exception in send()
URL: https://github.com/apache/flink/pull/8967#discussion_r303819178
##########
File path:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java
##########
@@ -140,10 +146,15 @@ protected Session createSession() {
public abstract ListenableFuture<V> send(IN value);
private void tryAcquire() throws InterruptedException, TimeoutException
{
Review comment:
Guess it is a matter of style; I removed the overloaded function, and just
call `tryAcquire(1)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
