xuefuz edited a comment on issue #9130: [FLINK-13274]Refactor 
HiveTableSourceTest using HiveRunner
URL: https://github.com/apache/flink/pull/9130#issuecomment-511892551
 
 
   Thanks for the contribution. While the changes look fine, I'm wondering if 
we should move a step further and change the test to use env.sqlQuery() to 
directly execute a sql query rather than HiveTableSource. I understand that 
this might not be ready at the moment, but I liked to point out.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to