wuchong commented on a change in pull request #8966:
[FLINK-13074][table-planner-blink] Add PartitionableTableSink bridge logic to
flink&blink …
URL: https://github.com/apache/flink/pull/8966#discussion_r304232440
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/runtime/utils/BatchTestBase.scala
##########
@@ -65,6 +66,12 @@ class BatchTestBase extends BatchAbstractTestBase {
val LINE_COL_TWICE_PATTERN: Pattern = Pattern.compile("(?s)From line
([0-9]+),"
+ " column ([0-9]+) to line ([0-9]+), column ([0-9]+): (.*)")
+ /**
+ * Subclass should overwrite this method if we want to overwrite
configuration during
+ * sql parse to sql to rel conversion phrase.
+ */
+ protected def getTableConfig: TableConfig = new TableConfig
Review comment:
It is confused we expose the create a new TableConfig. Because we use the
`tEnv.getConfig` to set a lot of configurations in `before()`. I think if we
want to set sql parser configurations, we can also override `before()` method
and add sql parse configs in `conf`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
