StefanRRichter commented on issue #9128: [FLINK-13256] Ensure periodical 
checkpoint still valid when region failover abort pending checkpoints
URL: https://github.com/apache/flink/pull/9128#issuecomment-512173085
 
 
   @Myasuka thanks for the fix, I think it solves the problem. One thing to 
think about is maybe to connect the concern of ensuring proper scheduling of 
the triggers closer to `failPendingCheckpoint()`. My reason is that failing a 
pending checkpoint can be the root cause of the problem that the trigger is not 
reestablished. But the symptom has currently to be fixed in multiple places 
that use this method, e.g. aborting checkpoints but also discarding 
checkpoints. This way of fixing would open the door for future problems, in 
case that more functionality is introduced that uses `failPendingCheckpoint()` 
but forgets about ensuring that triggers continue. Wdyt?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to