zentol commented on a change in pull request #9143: [FLINK-13307] Fix 
SourceStreamTaskTest test instability.
URL: https://github.com/apache/flink/pull/9143#discussion_r304347506
 
 

 ##########
 File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTaskTest.java
 ##########
 @@ -469,15 +477,20 @@ public void cancel() {
         */
        private static class ExceptionThrowingSource implements 
SourceFunction<String> {
 
+               private static volatile CompletableFuture<Void> isInRunLoop;
+
                private volatile boolean running = true;
-               static CompletableFuture<Void> isInRunLoop = new 
CompletableFuture<>();
 
                public static class TestException extends RuntimeException {
                        public TestException(String message) {
                                super(message);
                        }
                }
 
+               public static void setIsInRunLoop(@Nonnull final 
CompletableFuture<Void> waitingLatch) {
+                       ExceptionThrowingSource.isInRunLoop = waitingLatch;
+               }
+
                @Override
                public void run(SourceContext<String> ctx) throws TestException 
{
                        while (running) {
 
 Review comment:
   add checkState that the future is set

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to