bowenli86 commented on issue #9135: [FLINK-13296][table] FunctionCatalog.lookupFunction() should check in memory functions if the target function doesn't exist in catalog URL: https://github.com/apache/flink/pull/9135#issuecomment-512400523 @xuefuz thanks for your review! w.r.t the param, I haven't seen where `FunctionDefinitionFactory.createFunctionDefinition()` will need the database name, but wondering if I missed anything here. At this point, the CatalogFunction should already be retrieved with an ObjectPath. `FunctionDefinitionFactory.createFunctionDefinition()` doesn't talk to Catalog APIs, and the function name passed as 1st param is for the sole purpose of constructing a FunctionDefinition which requires a name. This is different from `TableFactory.createSource/Sink()`, which needs the database name to access partition information through Catalog APIs.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
