xuefuz commented on issue #9135: [FLINK-13296][table] FunctionCatalog.lookupFunction() should check in memory functions if the target function doesn't exist in catalog URL: https://github.com/apache/flink/pull/9135#issuecomment-512434796 I understand that database name is not used in HiveTableFactory.createFunctionDefinition(), but it's just the case presently and one implementation. It could be similarly used later or in other implementations. When that comes, we will have to introduce new API. On the other hand, if we add it now, it doesn't hurt if an implementation doesn't use that part. More importantly, it's more consistent with other APIs in the class. Nevertheless, I'm not strongly insisting. It's your call.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
