JingsongLi commented on a change in pull request #9139:
[FLINK-13304][table-runtime-blink] Fix implementation of getString and
getBinary method in NestedRow and add tests for complex data formats
URL: https://github.com/apache/flink/pull/9139#discussion_r304717224
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/NestedRow.java
##########
@@ -25,8 +25,12 @@
import static org.apache.flink.util.Preconditions.checkArgument;
/**
- * Its memory storage structure and {@link BinaryRow} exactly the same, the
only different is it supports
- * all bytes in variable MemorySegments.
+ * Its memory storage structure is exactly the same with {@link BinaryRow}.
+ * The only different is that, as {@link NestedRow} is used
+ * to store row value in the variable-length part of {@link BinaryRow},
+ * every field (including both fixed-length part and variable-length part) of
{@link NestedRow}
+ * has a possibility to cross the boundary of a segment, while the
fixed-length part of {@link BinaryRow}
+ * must fir into its first memory segment.
Review comment:
fir -> fit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
