wuchong commented on a change in pull request #9153: [FLINK-13315][table-api]
Port wmstrategies to api-java-bridge
URL: https://github.com/apache/flink/pull/9153#discussion_r304789719
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/stream/StreamExecTableSourceScan.scala
##########
@@ -173,7 +176,8 @@ class StreamExecTableSourceScan(
val watermarkGenerator = new
PeriodicWatermarkAssignerWrapper(rowtimeFieldIdx, p)
ingestedTable.assignTimestampsAndWatermarks(watermarkGenerator)
case p: PunctuatedWatermarkAssigner =>
- val watermarkGenerator = new
PunctuatedWatermarkAssignerWrapper(rowtimeFieldIdx, p)
+ val watermarkGenerator =
+ new PunctuatedWatermarkAssignerWrapper(rowtimeFieldIdx, p,
producedDataType)
Review comment:
Using `FlinkTypeFactory.toLogicalRowType(getRowType)` instead of
`producedDataType`? So that we can avoid to do the pattern match in
`PunctuatedWatermarkAssignerWrapper`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
