twalthr commented on a change in pull request #9049: [FLINK-13176][SQL CLI]
remember current catalog and database in SQL CLI SessionContext
URL: https://github.com/apache/flink/pull/9049#discussion_r304821308
##########
File path:
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/DependencyTest.java
##########
@@ -193,7 +200,20 @@ public Catalog createCatalog(String name, Map<String,
String> properties) {
ADDITIONAL_TEST_DATABASE,
new CatalogDatabaseImpl(new
HashMap<>(), null),
false);
- } catch (DatabaseAlreadyExistException e) {
+ hiveCatalog.createTable(
Review comment:
@bowenli86 please remove the Hive dependency from the SQL Client. For tests
would should follow a clear separation of concerns. We just want to test
catalog functionality so we can implement a dummy catalog. Combining multiple
modules to test end-to-end behavior should be done in an end-to-end test.
Otherwise we end up with complex module dependency structures that are actually
not necessary for testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
