docete commented on a change in pull request #9160: FLINK-13302][table-planner]
DateTimeUtils.unixDateCeil returns the same value as unixDateFloor does
URL: https://github.com/apache/flink/pull/9160#discussion_r304828240
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
##########
@@ -2447,13 +2447,13 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
'f16.ceil(TimeIntervalUnit.YEAR),
"f16.ceil(YEAR)",
"CEIL(f16 TO YEAR)",
- "1996-01-01")
+ "1997-01-01")
Review comment:
CEIL should returns a date equals or larger than the original one.
common-lang package provide the ceiling function in DateUtils class.
http://commons.apache.org/proper/commons-lang/javadocs/api-3.9/org/apache/commons/lang3/time/DateUtils.html#ceiling-java.util.Date-int-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
