xintongsong commented on a change in pull request #9105:
[FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory
size into wrong configuration instance.
URL: https://github.com/apache/flink/pull/9105#discussion_r304842163
##########
File path:
flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManagerTest.java
##########
@@ -829,4 +839,45 @@ public void testClearStateAfterRevokeLeadership() throws
Exception {
verify(rmServices.schedulerDriver).stop(true);
}};
}
+
+ /**
+ * Tests that RM and TM calculate same slot resource profile.
+ */
+ @Test
+ public void testCreateSlotsPerWorker() throws Exception {
Review comment:
It also came to my mind that whether these two test cases could share some
common component. My concern is where should add this common component to,
given that these two cases actually belong to two different modules (flink-yarn
and flink-mesos). I think it might be even worse to just have one not
self-contained component in one module and using it from two other modules.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
