hequn8128 edited a comment on issue #9141: [FLINK-12249][table] Fix type 
equivalence check problems for Window Aggregates
URL: https://github.com/apache/flink/pull/9141#issuecomment-513142925
 
 
   @dawidwys @godfreyhe @wuchong @sunjincheng121 Hi, I have updated the PR with 
the latest solution: In the LogicalWindowAggregateRule, change the types to the 
inferred types in the Aggregate and then cast back in the Project after 
Aggregate. 
   
   I think this makes sure the right semantics and also brings minor changes to 
the under-released Flink.  The long term solution as we discussed in the jira 
ticket should be considered later after 1.9. 
   
   Would be great if you can take a look.
   
   Best, Hequn

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to