GJL commented on a change in pull request #9113: [FLINK-13222] [runtime] Add
documentation for failover strategy option
URL: https://github.com/apache/flink/pull/9113#discussion_r305237712
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
##########
@@ -105,18 +105,27 @@
/**
* This option specifies the failover strategy, i.e. how the job
computation recovers from task failures.
+ * The option "individual" and "region-legacy" are intentionally not
included
+ * as they have some known limitations or issues.
+ * "individual" strategy only works when all tasks are not connected,
in which case the "region"
Review comment:
nit: Maybe format with `<ul>`
For example:
```
/**
* This option specifies the failover strategy, i.e. how the job
computation recovers from task failures.
*
* <p>The options "individual" and "region-legacy" are intentionally
not included
* as they have some known limitations or issues:
* <ul>
* <li>"individual" strategy only works when all tasks are not
connected,
* in which case the "region" failover strategy would also restart
failed tasks individually
* <li>"region-legacy" strategy is not able to backtrack missing
input result partitions
* </ul>
* The new "region" strategy supersedes "individual" and
"region-legacy" strategies and should always work.
*/
```
<img width="896" alt="image"
src="https://user-images.githubusercontent.com/1681921/61518527-0a41f380-aa0a-11e9-9d9f-fd1162733144.png";>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
![https://user-images.githubusercontent.com/1681921/61518527-0a41f380-aa0a-11e9-9d9f-fd1162733144.png"](https://user-images.githubusercontent.com/1681921/61518527-0a41f380-aa0a-11e9-9d9f-fd1162733144.png"){kind=link}