[
https://issues.apache.org/jira/browse/FLINK-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888747#comment-16888747
]
Timo Walther commented on FLINK-13335:
--------------------------------------
Hi Danny, it would be great if you can take this issue. I just took a deeper
look into the implementation and found many shortcomings that we should solve
to improve the user experience.
We implemented a logical type parser in FLINK-13078 that can be used for string
properties and annotations in the future. This parser should also be the
reference implementation for the Calcite-based SQL parser.
The data types of schema in CatalogTable that comes out the parsing step should
be equal to the ones defined in
{{org.apache.flink.table.types.LogicalTypeParserTest#testData}}. We should copy
this test spec over and verify the same behavior.
The parser can already be implemented feature-complete for those types. We
might need to throw unsupported exceptions in
{{org.apache.flink.table.sqlexec.SqlToOperationConverter#convertCreateTable}}
if the type factory is not able to handle the type yet.
> Align the SQL CREATE TABLE DDL with FLIP-37
> -------------------------------------------
>
> Key: FLINK-13335
> URL: https://issues.apache.org/jira/browse/FLINK-13335
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Blocker
> Fix For: 1.9.0
>
>
> At a first glance it does not seem that the newly introduced DDL is compliant
> with FLIP-37. We should ensure consistent behavior esp. also for corner cases.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
