zentol commented on a change in pull request #9165: [FLINK-13055] [runtime] Leverage JM tracked partitions to find out unavailable partitions in … URL: https://github.com/apache/flink/pull/9165#discussion_r305314766
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphResultPartitionAvailabilityChecker.java ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.executiongraph; + +import org.apache.flink.runtime.executiongraph.failover.flip1.ResultPartitionAvailabilityChecker; +import org.apache.flink.runtime.io.network.partition.PartitionTracker; +import org.apache.flink.runtime.jobgraph.IntermediateResultPartitionID; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * A {@link ResultPartitionAvailabilityChecker} which decides the intermediate result partition availability + * based on whether the corresponding result partition in the execution graph is tracked. + */ +public class ExecutionGraphResultPartitionAvailabilityChecker implements ResultPartitionAvailabilityChecker { + + /** The execution graph that hosts the result partitions. */ + private final ExecutionGraph executionGraph; + + /** The tracker that tracks all available result partitions. */ + private final PartitionTracker partitionTracker; + + ExecutionGraphResultPartitionAvailabilityChecker(final ExecutionGraph executionGraph) { Review comment: pass in a `Function<IntermediateResultPartitionID, ResultPartitionID>` instead; this can then be a simply method reference `ExecutionGraph::createResultPartitionId`. The `ExecutionGraphResultPartitionAvailabilityChecker` could then be simplified by quite a bit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
