zhijiangW commented on issue #9132: [FLINK-13245][network] Fix the bug of file 
resource leak while canceling partition request
URL: https://github.com/apache/flink/pull/9132#issuecomment-513301073
 
 
   @zentol , for the case of `SlotCountExceedingParallelismTest` it would not 
generate `ReleaseOnConsumptionResultPartition` because of blocking partition. 
Then the reference counter is not actually used for releasing partitions, but 
the partitions would finally be release via `RegionPartitionReleaseStrategy`.
   
   This PR change seems only make reference counter work for pipelined 
partitions. I run the `SlotCountExceedingParallelismTest` locally in Mac 
system, and it does not have file leaks before/after this fix. If in windows 
system it has file leaks then I guess it might be relevant with mmap mechanism 
in different systems.
   
   In addition, how do you test as mentioned above? Do you mean shutting down 
the cluster/job during test running? If the tests are not running finished, 
then it would indeed leftover `.channel` files.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to