kl0u commented on a change in pull request #9131: [FLINK-12858][checkpointing]
Stop-with-savepoint, workaround: fail whole job when savepoint is declined by a
task
URL: https://github.com/apache/flink/pull/9131#discussion_r305729949
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointFailureReason.java
##########
@@ -79,4 +79,38 @@
public String message() {
return message;
}
+
+ /**
+ * @return true if this value indicates a failure reason happening
before a checkpoint is passed to a job's tasks.
+ */
+ public boolean isPreFlight() {
Review comment:
I still believe that the flag is a better approach.
First of all from a readability standpoint, when someone opens the class
just to find is an exception is `preFlight` or not, he has to scan a method
with 20 `case` statements. Personally, I also do not like such methods also,
but this is just my personal taste.
And second, imagine if in the future we want to add another attribute. Then
we will have to add another method that enumerates all the exceptions and
another test that checks the completeness of the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
