twalthr commented on a change in pull request #9185: [FLINK-13266] [table]
Relocate blink planner classes to avoid class clashes
URL: https://github.com/apache/flink/pull/9185#discussion_r305809606
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/dataview/ListView.java
##########
@@ -106,7 +106,7 @@ public ListView() {
* Returns an iterable of the list view.
*
* @throws Exception Thrown if the system cannot get data.
- * @return The iterable of the list or { @code null} if the list is
empty.
+ * @return The iterable of the list.
Review comment:
This changes the API. We should return null instead, as documented. Remove
the `toString` method in this class. And fix `{ @code null}` to `{@code null}`.
Same applies for the MapView.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
