dmvk opened a new pull request #9200: [FLINK-13369] Add failing test case for cleaning circular dependencie… URL: https://github.com/apache/flink/pull/9200 …s using ClosureCleaner ## What is the purpose of the change Another issue I've run into while cleaning Beam's [AvroCoder](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/AvroCoder.java). In case of [circular dependency](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/AvroCoder.java#L271), cleaner ends up with StackOverflow. Providing a failing test case. Patch needs to track references of already accessed object before descending. ## Brief change log - *Added failing test case* ## Verifying this change This change added tests and can be verified as follows: - *Added test that tries to clean self-referencing closure ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (yes) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
