godfreyhe commented on issue #9185: [FLINK-13266] [table] Relocate blink planner classes to avoid class clashes URL: https://github.com/apache/flink/pull/9185#issuecomment-514022957 > From what I see, [2266617](https://github.com/apache/flink/commit/2266617d608ef5f22a75a6d6c6dc809f6f9df1f9) looks good to me for solving the class clashes. But maybe people that are more familiar with the module have further package improvement suggestions? @wuchong @KurtYoung Such a big refactoring does not happen often. Now is the time to improve the package structure a bit. E.g. we could find a better name than `org.apache.flink.table.planner.calcite`? But otherwise +1 from my side. thanks for your suggestion @twalthr , i will split [2266617](https://github.com/apache/flink/commit/2266617d608ef5f22a75a6d6c6dc809f6f9df1f9) into several smaller commits, and make sure each commits only involves "rename", no "delete/add". I and @wuchong have discussed `org.apache.flink.table.planner.calcite` offline: We deny `org.apache.flink.table.planner.optimizer`, because `org.apache.flink.table.plan` has a sub-package named `org.apache.flink.table.plann.optimize` which defines real `Optimizer`, and optimizer programs. I want to implement different strategy optimizer in `optimize` package in future. we think `org.apache.flink.table.planner.plan` is better than `org.apache.flink.table.planner.calcite`, because `plan` more accurately describes its function.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services