zhijiangW commented on a change in pull request #9170: [FLINK-13325][test] Add test to guard the fix for FLINK-13249 URL: https://github.com/apache/flink/pull/9170#discussion_r306178944
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TestTaskBuilder.java ########## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.taskmanager; + +import org.apache.flink.api.common.ExecutionConfig; +import org.apache.flink.api.common.JobID; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.runtime.blob.BlobCacheService; +import org.apache.flink.runtime.blob.PermanentBlobCache; +import org.apache.flink.runtime.blob.PermanentBlobKey; +import org.apache.flink.runtime.blob.TransientBlobCache; +import org.apache.flink.runtime.broadcast.BroadcastVariableManager; +import org.apache.flink.runtime.clusterframework.types.AllocationID; +import org.apache.flink.runtime.deployment.InputGateDeploymentDescriptor; +import org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptor; +import org.apache.flink.runtime.execution.ExecutionState; +import org.apache.flink.runtime.execution.librarycache.LibraryCacheManager; +import org.apache.flink.runtime.executiongraph.ExecutionAttemptID; +import org.apache.flink.runtime.executiongraph.JobInformation; +import org.apache.flink.runtime.executiongraph.TaskInformation; +import org.apache.flink.runtime.filecache.FileCache; +import org.apache.flink.runtime.io.disk.iomanager.IOManager; +import org.apache.flink.runtime.io.network.TaskEventDispatcher; +import org.apache.flink.runtime.io.network.partition.NoOpResultPartitionConsumableNotifier; +import org.apache.flink.runtime.io.network.partition.ResultPartitionConsumableNotifier; +import org.apache.flink.runtime.jobgraph.JobVertexID; +import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable; +import org.apache.flink.runtime.memory.MemoryManager; +import org.apache.flink.runtime.metrics.groups.TaskMetricGroup; +import org.apache.flink.runtime.metrics.groups.UnregisteredMetricGroups; +import org.apache.flink.runtime.operators.testutils.MockInputSplitProvider; +import org.apache.flink.runtime.query.KvStateRegistry; +import org.apache.flink.runtime.shuffle.ShuffleEnvironment; +import org.apache.flink.runtime.state.TestTaskStateManager; +import org.apache.flink.runtime.taskexecutor.KvStateService; +import org.apache.flink.runtime.taskexecutor.PartitionProducerStateChecker; +import org.apache.flink.runtime.taskexecutor.TestGlobalAggregateManager; +import org.apache.flink.runtime.testingUtils.TestingUtils; +import org.apache.flink.runtime.util.TestingTaskManagerRuntimeInfo; +import org.apache.flink.util.Preconditions; +import org.apache.flink.util.SerializedValue; + +import java.lang.reflect.Field; +import java.util.Collection; +import java.util.Collections; +import java.util.concurrent.Executor; + +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +/** + * Util that helps building {@link Task} objects for testing. + */ +public final class TestTaskBuilder { + private Class<? extends AbstractInvokable> invokable; + private TaskManagerActions taskManagerActions; + private LibraryCacheManager libraryCacheManager; + private ResultPartitionConsumableNotifier consumableNotifier; + private PartitionProducerStateChecker partitionProducerStateChecker; + private final ShuffleEnvironment<?, ?> shuffleEnvironment; + private KvStateService kvStateService; + private Executor executor; + private Configuration taskManagerConfig; + private ExecutionConfig executionConfig; + private Collection<PermanentBlobKey> requiredJarFileBlobKeys; + private Collection<ResultPartitionDeploymentDescriptor> resultPartitions = Collections.emptyList(); + private Collection<InputGateDeploymentDescriptor> inputGates = Collections.emptyList(); + + { + invokable = AbstractInvokable.class; + taskManagerActions = mock(TaskManagerActions.class); + + libraryCacheManager = mock(LibraryCacheManager.class); + when(libraryCacheManager.getClassLoader(any(JobID.class))).thenReturn(getClass().getClassLoader()); + + consumableNotifier = new NoOpResultPartitionConsumableNotifier(); + partitionProducerStateChecker = mock(PartitionProducerStateChecker.class); + + kvStateService = new KvStateService(new KvStateRegistry(), null, null); + + executor = TestingUtils.defaultExecutor(); + + taskManagerConfig = new Configuration(); + executionConfig = new ExecutionConfig(); + + requiredJarFileBlobKeys = Collections.emptyList(); + } + + public TestTaskBuilder(ShuffleEnvironment<?, ?> shuffleEnvironment) { + this.shuffleEnvironment = Preconditions.checkNotNull(shuffleEnvironment); + } + + public TestTaskBuilder setInvokable(Class<? extends AbstractInvokable> invokable) { + this.invokable = invokable; + return this; + } + + public TestTaskBuilder setTaskManagerActions(TaskManagerActions taskManagerActions) { + this.taskManagerActions = taskManagerActions; + return this; + } + + public TestTaskBuilder setLibraryCacheManager(LibraryCacheManager libraryCacheManager) { + this.libraryCacheManager = libraryCacheManager; + return this; + } + + public TestTaskBuilder setConsumableNotifier(ResultPartitionConsumableNotifier consumableNotifier) { + this.consumableNotifier = consumableNotifier; + return this; + } + + public TestTaskBuilder setPartitionProducerStateChecker(PartitionProducerStateChecker partitionProducerStateChecker) { + this.partitionProducerStateChecker = partitionProducerStateChecker; + return this; + } + + public TestTaskBuilder setKvStateService(KvStateService kvStateService) { + this.kvStateService = kvStateService; + return this; + } + + public TestTaskBuilder setExecutor(Executor executor) { + this.executor = executor; + return this; + } + + public TestTaskBuilder setTaskManagerConfig(Configuration taskManagerConfig) { + this.taskManagerConfig = taskManagerConfig; + return this; + } + + public TestTaskBuilder setExecutionConfig(ExecutionConfig executionConfig) { + this.executionConfig = executionConfig; + return this; + } + + public TestTaskBuilder setRequiredJarFileBlobKeys(Collection<PermanentBlobKey> requiredJarFileBlobKeys) { + this.requiredJarFileBlobKeys = requiredJarFileBlobKeys; + return this; + } + + public TestTaskBuilder setResultPartitions(Collection<ResultPartitionDeploymentDescriptor> resultPartitions) { + this.resultPartitions = resultPartitions; + return this; + } + + public TestTaskBuilder setInputGates(Collection<InputGateDeploymentDescriptor> inputGates) { + this.inputGates = inputGates; + return this; + } + + public Task build() throws Exception { + final JobID jobId = new JobID(); + final JobVertexID jobVertexId = new JobVertexID(); + final ExecutionAttemptID executionAttemptId = new ExecutionAttemptID(); + + final SerializedValue<ExecutionConfig> serializedExecutionConfig = new SerializedValue<>(executionConfig); + + final JobInformation jobInformation = new JobInformation( + jobId, + "Test Job", + serializedExecutionConfig, + new Configuration(), + requiredJarFileBlobKeys, + Collections.emptyList()); + + final TaskInformation taskInformation = new TaskInformation( + jobVertexId, + "Test Task", + 1, + 1, + invokable.getName(), + new Configuration()); + + final BlobCacheService blobCacheService = new BlobCacheService( + mock(PermanentBlobCache.class), + mock(TransientBlobCache.class)); + + final TaskMetricGroup taskMetricGroup = UnregisteredMetricGroups.createUnregisteredTaskMetricGroup(); + + return new Task( + jobInformation, + taskInformation, + executionAttemptId, + new AllocationID(), + 0, + 0, + resultPartitions, + inputGates, + 0, + mock(MemoryManager.class), Review comment: ditto: `MemoryManager` and `IOManager` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
