[
https://issues.apache.org/jira/browse/FLINK-13378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890781#comment-16890781
]
Jingsong Lee commented on FLINK-13378:
--------------------------------------
[~LouisXu777] Thanks for your nice catch. There are bugs now in blink-planner.
I agree point 1 and point 3. About point 3, you can see
SqlThrowExceptionFunction. It should be two args.
The singleValue Agg is for sql: select * from A where A.f0 < (select B.f0 from
B); But there is no cases now.
If we want to support it, we need solve bugs in RexNodeConverter and
PlannerExpressions. Do you want solve them before 1.9 release?
> Wrong comment in SingleValueAggFunction.accumulateExpressions()
> ---------------------------------------------------------------
>
> Key: FLINK-13378
> URL: https://issues.apache.org/jira/browse/FLINK-13378
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
> Affects Versions: 1.9.0, 1.10.0
> Reporter: Louis Xu
> Priority: Major
> Fix For: 1.10.0
>
>
> 1.The comment in the method is "value = count == 0 ? exception : operand(0)",
> but actually it need to be "value = count > 0 ? exception : operand(0)"
> according to the code and logic.
> 2.And the "throwException" expression's parameter msg is never used. And if
> we only think about "throwException" expression, the param "type" is the
> return type of agg function or msg's type? I don't known the definition of
> "throwException" expression, but I think this might be some problem.
> 3.If we need use param msg, the expression is call(THROW_EXCEPTION,
> literal(msg, type)) or
> call(THROW_EXCEPTION, literal(msg), typeLiteral(type)).
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
