JingsongLi opened a new pull request #9208: [FLINK-13378][table-planner-blink] Fix bug: Blink-planner not support SingleValueAggFunction URL: https://github.com/apache/flink/pull/9208 ## What is the purpose of the change There some problem in SingleValueAggFunction: 1.The comment in the method is "value = count == 0 ? exception : operand(0)", but actually it need to be "value = count > 0 ? exception : operand(0)" according to the code and logic. 2.The throwException expression should call(THROW_EXCEPTION, literal(msg), typeLiteral(type)). And there are some bugs to support it in blink-planner: 1.RexNodeConverter lack converter for THROW_EXCEPTION 2.PlannerExpressions lack expr to support type inference for THROW_EXCEPTION ## Verifying this change ScalarQueryITCase ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
