twalthr commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions URL: https://github.com/apache/flink/pull/9203#issuecomment-514521984 5 Levels for special cases like `table.optimizer.distinct-agg.split.bucket-num` is fine with me. However, I think if we introduce new options under a common key that needs a hierarchy, we could still deprecate the old flat key and introduce the hierarchy. Introducing hierarchy "just in case" should be avoided. If options are not relative to a specific operator, they should become top-level properties: `table.optimizer.reuse-sub-plan-enabled` instead of `table.optimizer.reuse.sub-plan.enabled`. I know this topic is typical bikeshedding so I don't want to block too much here. But it would be great if you could go through the list one more time and check whether a hierarchy makes sense. Thanks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
