NicoK commented on a change in pull request #9132: [FLINK-13245][network] Fix 
the bug of file resource leak while canceling partition request
URL: https://github.com/apache/flink/pull/9132#discussion_r306746174
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueueTest.java
 ##########
 @@ -54,6 +66,22 @@
  */
 public class PartitionRequestQueueTest {
 
+       private static final String TEMP_DIR = 
EnvironmentInformation.getTemporaryFileDirectory();
 
 Review comment:
   Why don't you use this?
   ```
        @ClassRule
        public static final TemporaryFolder TEMPORARY_FOLDER = new 
TemporaryFolder();
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to