[ 
https://issues.apache.org/jira/browse/FLINK-13228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891808#comment-16891808
 ] 

Yu Li commented on FLINK-13228:
-------------------------------

Please check the demo patch, actually all other test cases will fail (except 
for {{testCloseWithNoData}} which has no try-with-resource) with the v2 hadoop 
patch, so the final PR will change all test methods in a similar way.

And the given patch could also fix FLINK-12071 (actually these two are 
duplicates with the same root cause). For example, below is the exception I 
observed for {{testExceptionWritingAfterCloseForCommit}} with v2 hadoop patch
{noformat}
Caused by: java.lang.IllegalArgumentException: Self-suppression not permitted
        at java.lang.Throwable.addSuppressed(Throwable.java:1043)
        at 
org.apache.flink.core.fs.AbstractRecoverableWriterTest.testExceptionWritingAfterCloseForCommit(AbstractRecoverableWriterTest.java:308)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at 
org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:19)
        ... 22 more
Caused by: java.io.IOException: The stream is closed
        at 
org.apache.hadoop.net.SocketOutputStream.write(SocketOutputStream.java:147)
        at 
java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82)
        at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140)
        at java.io.DataOutputStream.flush(DataOutputStream.java:123)
        at java.io.FilterOutputStream.close(FilterOutputStream.java:158)
        at 
org.apache.hadoop.hdfs.DataStreamer.closeStream(DataStreamer.java:987)
        at 
org.apache.hadoop.hdfs.DataStreamer.closeInternal(DataStreamer.java:839)
        at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:834)
        Suppressed: java.io.IOException: The stream is closed
                at 
org.apache.hadoop.net.SocketOutputStream.write(SocketOutputStream.java:147)
                at 
java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82)
                at 
java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140)
                at java.io.FilterOutputStream.close(FilterOutputStream.java:158)
                at java.io.FilterOutputStream.close(FilterOutputStream.java:159)
                ... 3 more
{noformat}

> HadoopRecoverableWriterTest.testCommitAfterNormalClose fails on Travis
> ----------------------------------------------------------------------
>
>                 Key: FLINK-13228
>                 URL: https://issues.apache.org/jira/browse/FLINK-13228
>             Project: Flink
>          Issue Type: Bug
>          Components: FileSystems
>    Affects Versions: 1.9.0
>            Reporter: Till Rohrmann
>            Assignee: Yu Li
>            Priority: Critical
>              Labels: test-stability
>             Fix For: 1.9.0
>
>         Attachments: FLINK-13228.hadoop.debug.patch, 
> FLINK-13228.hadoop.debug.v2.patch, FLINK-13288.demo.patch
>
>
> {{HadoopRecoverableWriterTest.testCommitAfterNormalClose}} failed on Travis 
> with
> {code}
> HadoopRecoverableWriterTest.testCommitAfterNormalClose » IO The stream is 
> closed
> {code}
> https://api.travis-ci.org/v3/job/557293706/log.txt



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to