[
https://issues.apache.org/jira/browse/FLINK-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891826#comment-16891826
]
vinoyang commented on FLINK-13143:
----------------------------------
Hi [~till.rohrmann] I think you misunderstood my thought. I do not try to
remove {{CheckpointConfig#setFailOnCheckpointingErrors}}. What I mean is that
we could remove {{CheckpointExceptionHandler}},
{{CheckpointExceptionHandlerFactory}} and
{{DecliningCheckpointExceptionHandler}} and relevant test classes. I mentioned
{{CheckpointConfig#setFailOnCheckpointingErrors}}, just want to point that
these classes do not take any effect. All of these things can be simplified to
one line:
{code:java}
environment.declineCheckpoint(checkpointMetaData.getCheckpointId(), exception);
{code}
WDYT?
> Refactor CheckpointExceptionHandler relevant classes
> ----------------------------------------------------
>
> Key: FLINK-13143
> URL: https://issues.apache.org/jira/browse/FLINK-13143
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Checkpointing
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Major
>
> Since FLINK-11662 has been merged, we can clear
> {{CheckpointExceptionHandler}} relevant classes.
> {{CheckpointExceptionHandler}} used to implement
> {{setFailOnCheckpointingErrors}}. Now, it has only one implementation which
> is {{DecliningCheckpointExceptionHandler}}.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
