dmvk commented on issue #9022: [FLINK-13127] Fix --yarnship classpath URL: https://github.com/apache/flink/pull/9022#issuecomment-514624031 @xintongsong @TisonKun thanks for the review! For points 1) and 2), I've updated a test case and removed duplicated code in `org.apache.flink.yarn.AbstractYarnClusterDescriptor#uploadAndRegisterFiles` method. I don't think there is any significant benefit of sorting those, the idea was to make sure that it is deterministic, but that would be probably the case without sorting anyway. I don't have any strong arguments for this, so I can remove it if you want to. Thanks!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
