shuai-xu commented on a change in pull request #9175: [FLINK-12038] [test] fix
YARNITCase random fail
URL: https://github.com/apache/flink/pull/9175#discussion_r307105775
##########
File path:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java
##########
@@ -573,6 +576,23 @@ public static int getRunningContainers() {
return count;
}
+ void waitUntilApplicationFinished(ApplicationId applicationId, Duration
timeout) throws Exception {
+ Deadline deadline = Deadline.now().plus(timeout);
+ while (true) {
Review comment:
This may lead to unnecessary `sleep`, I change it to `while (state !=
YarnApplicationState.FINISHED) {}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
