xintongsong commented on a change in pull request #9022: [FLINK-13127] Fix
--yarnship classpath
URL: https://github.com/apache/flink/pull/9022#discussion_r307750640
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
##########
@@ -459,11 +459,11 @@ public void testEnvironmentPluginsShipping() throws
Exception {
testEnvironmentDirectoryShipping(ConfigConstants.ENV_FLINK_PLUGINS_DIR);
}
- public void testEnvironmentDirectoryShipping(String
environmentVariable) throws Exception {
Review comment:
The three changes in this file seems to be clean-ups that are irrelevant to
the problem this PR solves. It would probably be better that such changes go
into a separate commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
