[ 
https://issues.apache.org/jira/browse/FLINK-13436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16893957#comment-16893957
 ] 

Yu Li commented on FLINK-13436:
-------------------------------

After some offline discussion with [~till.rohrmann] and [~twalthr], we all 
agree that it's safer to check the whole path from submitting sql query from 
cli, running on a real cluster to returning the result, so making it end-to-end 
test is necessary rather than adding an IT case.

Checking the initial patch for IT case (kind of big so won't upload it here), I 
think we have the below TODO items to get the job done:

# Figure out how to generate the TPCH data and use it legally (prevent any 
licensing issue).
** FWIW, we may refer to the https://github.com/databricks/tpch-dbgen repo.
# Write SQL commands for TPCH query.
# Add a script to 1) start a cluster, 2) invoke the data generator, 3) submit 
the SQL query from cli, and 4) verifying the result. Refer to 
{{flink-end-to-end-tests/test-scripts/test_batch_allround.sh}} as a sample.

I could help on the 3rd one but need some help on the other two due to lack of 
background. [~lzljs3620320] [~TsReaper]

Thanks.

> Add TPC-H queries as E2E tests
> ------------------------------
>
>                 Key: FLINK-13436
>                 URL: https://issues.apache.org/jira/browse/FLINK-13436
>             Project: Flink
>          Issue Type: Test
>          Components: Table SQL / Planner, Tests
>    Affects Versions: 1.9.0
>            Reporter: Till Rohrmann
>            Priority: Blocker
>             Fix For: 1.9.0
>
>
> We should add the TPC-H queries as E2E tests in order to verify the blink 
> planner.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to