tillrohrmann commented on a change in pull request #9242:
[FLINK-13408][runtime] Schedule
StandaloneResourceManager.setFailUnfulfillableRequest whenever the leadership
is acquired
URL: https://github.com/apache/flink/pull/9242#discussion_r307811139
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
##########
@@ -201,7 +201,6 @@ public MesosResourceManager(
final ContaineredTaskManagerParameters
containeredTaskManagerParameters =
taskManagerParameters.containeredParameters();
this.slotsPerWorker =
updateTaskManagerConfigAndCreateWorkerSlotProfiles(
flinkConfig,
containeredTaskManagerParameters.taskManagerTotalMemoryMB(),
containeredTaskManagerParameters.numSlots());
- setFailUnfulfillableRequest(true);
Review comment:
This is a good finding. Don't we have tests for Mesos which test this
behavior? Given the previous code, unfulfillable requests should have failed
right away, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
