xuefuz commented on a change in pull request #9239: [FLINK-13385]Align Hive 
data type mapping with FLIP-37
URL: https://github.com/apache/flink/pull/9239#discussion_r307830806
 
 

 ##########
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTypeUtil.java
 ##########
 @@ -146,6 +143,11 @@ public static TypeInfo toHiveTypeInfo(DataType dataType) {
                        // Flink's primitive types that Hive 2.3.4 doesn't 
support: Time, TIMESTAMP_WITH_LOCAL_TIME_ZONE
                }
 
+               if (dataType.equals(DataTypes.BYTES())) {
+                       // Hive doesn't support variable-length binary string
 
 Review comment:
   The comment doesn't seem applicable in the code context. Let's remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to