xintongsong opened a new pull request #9242: [FLINK-13408][runtime] Schedule 
StandaloneResourceManager.setFailUnfulfillableRequest whenever the leadership 
is acquired
URL: https://github.com/apache/flink/pull/9242
 
 
   ## What is the purpose of the change
   
   We introduced `StandaloneResourceManager#setFailUnfulfillableRequest` to 
give some time to task executors to register the available slots before the 
slot requests can be checked whether they can be fulfilled or not. 
`setFailUnfulfillableRequest` is scheduled now only once when the RM is 
initialized but the task executors will register themselves every time this RM 
gets the leadership. Hence, `setFailUnfulfillableRequest` should be scheduled 
after each leader election.
   
   ## Brief change log
   
   - 5ff534941925c49556462d188b9457334b4f1026: Override 
`StandaloneResourceManager#setFailUnfulfillableRequest` to schedule invoking 
`ResourceManager#setFailUnfulfillableRequest` respecting the start up period.
   - e41db5e0470c5de4bf998c4fb4b6ca719fd6acb3: Resource managers set fail 
unfulfillable requests when leadership is granted, and reset it when leadership 
is revoked.
   - bc4bc3a00e1692381368af36b87d233677e8c4ac: Add 
`StandaloneResourceManagerTest#testStartUpPeriodAfterLeadershipSwitch` 
validates that StandaloneResourceManager applies a startup period whenever the 
leadership is acquired.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - Add `StandaloneResourceManagerTest#testStartUpPeriodAfterLeadershipSwitch` 
validates that StandaloneResourceManager applies a startup period whenever the 
leadership is acquired.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to