godfreyhe commented on a change in pull request #9219: [FLINK-13404] [table] 
Port csv factories and descriptors to flink-csv
URL: https://github.com/apache/flink/pull/9219#discussion_r308147136
 
 

 ##########
 File path: flink-formats/flink-csv/pom.xml
 ##########
 @@ -58,31 +58,24 @@ under the License.
                        <scope>provided</scope>
                </dependency>
 
-               <!-- test dependencies -->
-
-               <!-- CSV table descriptor testing -->
                <dependency>
                        <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-table-common</artifactId>
+                       
<artifactId>flink-table-api-java-bridge_${scala.binary.version}</artifactId>
 
 Review comment:
   @twalthr , just as @wuchong mentioned, `CsvTableSource` and `CsvTableSink` 
are in `flink-table-api-java-bridge` now,  and `CsvTableSourceFactoryBase` and 
`CsvTableSinkFactoryBase` depend on them. one solution is : porting 
`CsvTableSource` and `CsvTableSink` to `flink-csv` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to