kl0u commented on a change in pull request #9207: [FLINK-9526][e2e] Fix
unstable BucketingSink end-to-end test
URL: https://github.com/apache/flink/pull/9207#discussion_r308154823
##########
File path: flink-end-to-end-tests/test-scripts/test_streaming_bucketing.sh
##########
@@ -22,7 +22,8 @@ source "$(dirname "$0")"/common.sh
TEST_PROGRAM_JAR=${END_TO_END_DIR}/flink-bucketing-sink-test/target/BucketingSinkTestProgram.jar
# enable DEBUG logging level to retrieve truncate length later
-sed -i -e
's/#log4j.logger.org.apache.flink=INFO/log4j.logger.org.apache.flink=DEBUG/g'
$FLINK_DIR/conf/log4j.properties
+echo "" >> $FLINK_DIR/conf/log4j.properties
+echo
"log4j.logger.org.apache.flink.streaming.connectors.fs.bucketing.BucketingSink=DEBUG,
file" >> $FLINK_DIR/conf/log4j.properties
Review comment:
The only thing needed is the `echo
"log4j.logger.org.apache.flink.streaming.connectors.fs.bucketing.BucketingSink=DEBUG`.
The appender is already inherited by the root logger, so the `, file` is
redundant, and the `echo "" >> $FLINK_DIR/conf/log4j.properties` does not add
any additional information, so it can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
