sunhaibotb commented on issue #8742: [FLINK-11879] Add validators for the uses of InputSelectable, BoundedOneInput and BoundedMultiInput URL: https://github.com/apache/flink/pull/8742#issuecomment-515958576 The code has been updated. Because of the conflict with the latest master branch, I rebased on the latest master and forcibly pushed. A new problem is that batch and streaming will share some operators, some of which may need to implement `Bounded[Multi|One]Input` in the batch mode to do something in the `endInput()` method, such as `ContinuousFileReaderOperator` (please look at [issue#13376](https://issues.apache.org/jira/browse/FLINK-13376)). But if these operators implement `Bounded[Multi|One]Input`, streaming will not be able to use them because of the validation in this PR. After I re-checked the code related to the checkpoint handler, I think that there was no need to add the validator for the use of `Bounded[Multi|One]Input`. Because as long as an `EndOfPartition` event arrives, the current checkpointing mechanism will not generate a successful checkpoint after that. That is, failure to handle the `endInput` state for checkpointing does not cause correctness problems. What do you think? @pnowojski (In the latest code of this PR, I've removed the validation on `Bounded[Multi|One]Input`. If I'm wrong, I'll add it back.)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
