[
https://issues.apache.org/jira/browse/FLINK-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909232#comment-14909232
]
ASF GitHub Bot commented on FLINK-1789:
---------------------------------------
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/593#discussion_r40493024
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java
---
@@ -51,12 +50,25 @@ public void testJobWithCustomInputFormat() {
PackagedProgram inputSplitTestProg = new
PackagedProgram(new File(INPUT_SPLITS_PROG_JAR_FILE),
new String[] {
INPUT_SPLITS_PROG_JAR_FILE,
+
"", // classpath
"localhost",
String.valueOf(port),
"4" // parallelism
} );
inputSplitTestProg.invokeInteractiveModeForExecution();
+
+
+ String classpath = new
File(INPUT_SPLITS_PROG_JAR_FILE).toURI().toURL().toString();
+ PackagedProgram inputSplitTestProg2 = new
PackagedProgram(new File(INPUT_SPLITS_PROG_JAR_FILE),
+ new String[] { "",
+
classpath, // classpath
+
"localhost",
+
String.valueOf(port),
+
"4" // parallelism
+ } );
+
inputSplitTestProg2.invokeInteractiveModeForExecution();
+
--- End diff --
Looks like I wrote this comment before testing the functionality ;) It
seems that the test does not detect the issues I found with manual testing.
> Allow adding of URLs to the usercode class loader
> -------------------------------------------------
>
> Key: FLINK-1789
> URL: https://issues.apache.org/jira/browse/FLINK-1789
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Minor
>
> Currently, there is no option to add customs classpath URLs to the
> FlinkUserCodeClassLoader. JARs always need to be shipped to the cluster even
> if they are already present on all nodes.
> It would be great if RemoteEnvironment also accepts valid classpaths URLs and
> forwards them to BlobLibraryCacheManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
