JingsongLi commented on a change in pull request #9275:
[FLINK-13290][table-planner-blink][hbase] SinkCodeGenerator should not compare
row type field names and enable blink planner for hbase IT case
URL: https://github.com/apache/flink/pull/9275#discussion_r308676085
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/SinkCodeGenerator.scala
##########
@@ -108,8 +108,7 @@ object SinkCodeGenerator {
val inputTerm = CodeGenUtils.DEFAULT_INPUT1_TERM
var afterIndexModify = inputTerm
val fieldIndexProcessCode =
- if (getCompositeTypes(convertOutputType).map(fromTypeInfoToLogicalType)
sameElements
- inputTypeInfo.getFieldTypes.map(fromTypeInfoToLogicalType)) {
+ if (getCompositeTypes(convertOutputType) sameElements
inputTypeInfo.getFieldTypes) {
Review comment:
it not work now...
`inputTypeInfo` is a BaseRowTypeInfo with internal type informations.
And `convertOutputType` is the type information from sink and users.
Consider Types.STRING and BinaryStringTypeInfo, Types.DECIMAL and
DecimalTypeInfo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
