tillrohrmann commented on a change in pull request #9269: [FLINK-9900][tests]
Fix unstable ZooKeeperHighAvailabilityITCase
URL: https://github.com/apache/flink/pull/9269#discussion_r308755854
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ZooKeeperHighAvailabilityITCase.java
##########
@@ -366,6 +369,11 @@ public void snapshotState(FunctionSnapshotContext
context) throws Exception {
failInCheckpointLatch.await();
if (!failedAlready.getAndSet(true)) {
throw new RuntimeException("Failing on
purpose.");
+ } else {
+ // make sure there would be no more
successful checkpoint before job failing
+ // otherwise there might be a
successful checkpoint 7 which is unexpected
+ // we expect checkpoint 5 is the last
successful one before ha storage recovering
+ blockSnapshotLatch.await();
Review comment:
This might block the `Task` thread indefinitely until it is interrupted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
